Add zammad module #37

Merged
adb-sh merged 7 commits from feature/zammad into master 2023-12-11 19:27:07 +01:00
adb-sh commented 2023-11-07 22:01:51 +01:00 (Migrated from github.com)

deploy zammad service

deploy zammad service
tanneberger (Migrated from github.com) requested changes 2023-12-06 01:09:00 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
tanneberger (Migrated from github.com) commented 2023-12-06 01:04:35 +01:00

maybe a bit to generic: suggestions: kanban.dd-ix.netor tickets.dd-ix.net

maybe a bit to generic: suggestions: `kanban.dd-ix.net`or `tickets.dd-ix.net`
tanneberger (Migrated from github.com) commented 2023-12-06 01:05:30 +01:00

not necessary (and even if pls move it into some nginx.nix or smth like this)

not necessary (and even if pls move it into some nginx.nix or smth like this)
tanneberger (Migrated from github.com) commented 2023-12-06 01:06:30 +01:00

I dont see the point in the config where the database users password is set.

(taken from vaultwarden)

systemd.services.vaultwarden-pgsetup = {
    description = "Prepare postgres database";
    wantedBy = [ "multi-user.target" ];
    after = [ "networking.target" "postgresql.service" ];
    serviceConfig.Type = "oneshot";

    path = [ pkgs.sudo config.services.postgresql.package ];
    script = ''
      # create postgres user with the specified password
      sudo -u ${config.services.postgresql.superUser} psql -c "ALTER ROLE vaultwarden WITH PASSWORD '$(cat ${config.sops.secrets.postgres_vaultwarden.path})'"
    '';
  };

alternatively, you also can put it into

systemd.services.postgresql.postStart

I dont see the point in the config where the database users password is set. (taken from vaultwarden) ```nix systemd.services.vaultwarden-pgsetup = { description = "Prepare postgres database"; wantedBy = [ "multi-user.target" ]; after = [ "networking.target" "postgresql.service" ]; serviceConfig.Type = "oneshot"; path = [ pkgs.sudo config.services.postgresql.package ]; script = '' # create postgres user with the specified password sudo -u ${config.services.postgresql.superUser} psql -c "ALTER ROLE vaultwarden WITH PASSWORD '$(cat ${config.sops.secrets.postgres_vaultwarden.path})'" ''; }; ``` alternatively, you also can put it into `systemd.services.postgresql.postStart`
tanneberger commented 2023-12-07 00:33:41 +01:00 (Migrated from github.com)

And I would also refer you to our ifsr config where zammad already runs in production under reasonable load and criticality.
https://github.com/fsr/fruitbasket/blob/main/modules/zammad.nix

And I would also refer you to our ifsr config where zammad already runs in production under reasonable load and criticality. https://github.com/fsr/fruitbasket/blob/main/modules/zammad.nix
adb-sh (Migrated from github.com) reviewed 2023-12-07 10:19:21 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
adb-sh (Migrated from github.com) commented 2023-12-07 10:19:21 +01:00

wanted to keep the tickets-Subdomain free for a potential Pretix-installation. what about management or orga ?

wanted to keep the `tickets`-Subdomain free for a potential Pretix-installation. what about `management` or `orga` ?
adb-sh (Migrated from github.com) reviewed 2023-12-07 10:32:07 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
adb-sh (Migrated from github.com) commented 2023-12-07 10:32:07 +01:00

yup, forgot about that. would you consider using database.createLocally = true; without setting the db-password declarative in the first place to be best practice?

yup, forgot about that. would you consider using `database.createLocally = true;` without setting the db-password declarative in the first place to be best practice?
tanneberger (Migrated from github.com) reviewed 2023-12-08 16:33:19 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
tanneberger (Migrated from github.com) commented 2023-12-08 16:33:19 +01:00

using createLocally is totally fine

using createLocally is totally fine
tanneberger (Migrated from github.com) reviewed 2023-12-08 16:33:43 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
tanneberger (Migrated from github.com) commented 2023-12-08 16:33:43 +01:00

orga sounds good

orga sounds good
adb-sh (Migrated from github.com) reviewed 2023-12-08 17:45:34 +01:00
@ -0,0 +1,46 @@
{ config, pkgs, ... }:
adb-sh (Migrated from github.com) commented 2023-12-08 17:45:34 +01:00

removed as it is already captured in nginx.nix

removed as it is already captured in nginx.nix
tanneberger (Migrated from github.com) approved these changes 2023-12-11 19:26:49 +01:00
Sign in to join this conversation.
No description provided.