dd-ix/akvorado-stats
Watch
7
0
Fork
You've already forked akvorado-stats
 0
Code Issues 1 Pull requests 1 Projects Releases Wiki Activity

updating README.md #7

Merged
tanneberger merged 4 commits from systemd-cron into main 2024-07-29 20:46:41 +02:00
Conversation 2 Commits 4 Files changed 2 +50 -3
tanneberger commented 2024-07-27 23:29:43 +02:00 (Migrated from github.com)
Copy link
No description provided.
liske (Migrated from github.com) reviewed 2024-07-27 23:29:43 +02:00
liske (Migrated from github.com) requested changes 2024-07-28 11:17:32 +02:00
README.md
liske (Migrated from github.com) commented 2024-07-28 11:06:38 +02:00
Copy link

I would prefer to split the clickhouse export description from the other scripts in this repository. Let's move most of this content to akvo-top-asn/README.md and add only a small overview & toc in the top level.

I would prefer to split the clickhouse export description from the other scripts in this repository. Let's move most of this content to `akvo-top-asn/README.md` and add only a small overview & toc in the top level.
liske (Migrated from github.com) commented 2024-07-28 11:08:51 +02:00
Copy link

Putting scripts in /var/lib violates the FHS and I dislike it, too. Please consider to use /usr/src, /usr/local/lib or /opt.

Putting scripts in `/var/lib` violates the FHS and I dislike it, too. Please consider to use `/usr/src`, `/usr/local/lib` or `/opt`.
liske (Migrated from github.com) commented 2024-07-28 11:12:19 +02:00
Copy link

There are missing details about the python dependencies. Since clickhouse-connect might not packaged at most linux distris we should add some details about using a virtualenv in the timers.

There are missing details about the python dependencies. Since `clickhouse-connect` might not packaged at most linux distris we should add some details about using a virtualenv in the timers.
liske (Migrated from github.com) commented 2024-07-28 11:13:51 +02:00
Copy link

This script is not DD-IX specific nor is the export itself. We should keep the name of the script and the service consistent.

This script is not DD-IX specific nor is the export itself. We should keep the name of the script and the service consistent.
liske (Migrated from github.com) commented 2024-07-28 11:15:36 +02:00
Copy link

The --week 1 parameter is already the default. This command won't work as it is missing one of the required action parameters (i.e. --upload).

The `--week 1` parameter is already the default. This command won't work as it is missing one of the required action parameters (i.e. `--upload`).
liske (Migrated from github.com) commented 2024-07-28 11:16:28 +02:00
Copy link

It looks like running this script as root which would be a bad practice.

It looks like running this script as `root` which would be a bad practice.
Sign in to join this conversation.
Reviewers
No reviewers
liske
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
dd-ix/akvorado-stats!7
No description provided.